Skip to content

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Dec 9, 2025

The comments described this get-or-default, but instead it was a panic

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the fix label Dec 9, 2025
@gatesn gatesn enabled auto-merge (squash) December 9, 2025 10:01
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 9, 2025

CodSpeed Performance Report

Merging #5662 will improve performances by 12.72%

Comparing ngates/session-default (b65128a) with develop (dcd42d2)

Summary

⚡ 1 improvement
✅ 1157 untouched
⏩ 617 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Change
encode_specialized 2.7 ms 2.4 ms +12.72%

Footnotes

  1. 617 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 25.92593% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.26%. Comparing base (dcd42d2) to head (b65128a).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-session/src/lib.rs 25.92% 20 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gatesn gatesn merged commit b9c87f1 into develop Dec 9, 2025
85 checks passed
@gatesn gatesn deleted the ngates/session-default branch December 9, 2025 10:20
peasee pushed a commit to spiceai/vortex that referenced this pull request Dec 10, 2025
The comments described this get-or-default, but instead it was a panic

---------

Signed-off-by: Nicholas Gates <nick@nickgates.com>
peasee added a commit to spiceai/vortex that referenced this pull request Dec 10, 2025
* Fix session get-or-default (vortex-data#5662)

The comments described this get-or-default, but instead it was a panic

---------

Signed-off-by: Nicholas Gates <nick@nickgates.com>

* feat: Support retrieving writer strategy builder from vortex session

---------

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Co-authored-by: Nicholas Gates <gatesn@users.noreply.github.com>
gatesn added a commit that referenced this pull request Dec 11, 2025
I was seeing increasing contention from #5662

The alternate and more invasive fix is in #5685 , but we should decide
if we want to allowing registering plugins after "startup", and what
that means for language bindings that use a global static session
object.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants