Skip to content

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Jan 5, 2026

This PR introduces an extendable interface for converting DataFusion physical expressions into Vortex ones, so that users can define their own behavior for UDFs or any other home-brewed physical expressions.

I think this is an OK way to expose the defaults for now, but would appreciate thoughts.

@AdamGS AdamGS requested review from asubiotto and gatesn January 5, 2026 12:37
@AdamGS AdamGS added the feature Release label indicating a new feature or request label Jan 5, 2026
@AdamGS AdamGS force-pushed the adamg/df-expr-conversion branch from cd7ec1a to 2dc9f3e Compare January 5, 2026 12:42
@AdamGS AdamGS marked this pull request as ready for review January 5, 2026 12:43
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 82.97872% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.99%. Comparing base (59bcf21) to head (ff59093).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-datafusion/src/convert/exprs.rs 88.46% 9 Missing ⚠️
vortex-datafusion/src/persistent/source.rs 22.22% 7 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AdamGS AdamGS force-pushed the adamg/df-expr-conversion branch from 2dc9f3e to e6d4f1d Compare January 5, 2026 13:36
@AdamGS AdamGS force-pushed the adamg/df-expr-conversion branch from e6d4f1d to de7880f Compare January 5, 2026 15:45
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/df-expr-conversion branch from de7880f to ff59093 Compare January 5, 2026 16:16
@AdamGS AdamGS merged commit 1b73409 into develop Jan 5, 2026
47 checks passed
@AdamGS AdamGS deleted the adamg/df-expr-conversion branch January 5, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Release label indicating a new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants