Skip to content

Conversation

@eikehartmann
Copy link
Contributor

@eikehartmann eikehartmann commented Jan 26, 2020

Fixes #198

  • given a domain vouch.github.io as config value vouch.domains and user with email vouch.github.io@yahoo.com

    • expected result: User won't be authorised.
    • actual result: User is authorised.
    • patched result: User won't be authorised.
  • given a domain easy.vouch.io as config value vouch.domains and user with email test@uneasy.vouch.io

    • expected result: User won't be authorised.
    • actual result: User is authorised.
    • patched result: User won't be authorised.

From looking at the code, domains.IsUnderManagement(user.Email) which uses domain.Matches() method will create the misbehaviour described above. The PR should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When domains configured, access via email on different domain should not be possible.

2 participants