This repository was archived by the owner on Mar 2, 2022. It is now read-only.
Full response is now returned for all methods.#5
Open
danijel-bjelancevic wants to merge 1 commit intovoxbone:masterfrom
Open
Full response is now returned for all methods.#5danijel-bjelancevic wants to merge 1 commit intovoxbone:masterfrom
danijel-bjelancevic wants to merge 1 commit intovoxbone:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All methods were returning only body of the response. Often the body comes out broken by missing first several characters. It happens because wrong header size is returned by curl and it's being relied on to split the response correctly.
Also, having the full response is more practical by giving a lot more options and potential for building wrappers around the API client.