Conversation
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
============================================
- Coverage 44.97% 40.14% -4.83%
+ Complexity 1400 1270 -130
============================================
Files 273 273
Lines 9613 9680 +67
Branches 1121 1127 +6
============================================
- Hits 4323 3886 -437
- Misses 4860 5442 +582
+ Partials 430 352 -78 Continue to review full report at Codecov.
|
| } | ||
| } | ||
| if (properties.isMeterLocks()) { | ||
| Gauge.builder("locks.currentCount", ObjectLockerAdmin.JMX_INSTANCE, ObjectLockerAdmin::getCurrentCount) |
There was a problem hiding this comment.
Use lower case by convention zo current.count. Not sure wether "count" provides the strongest semantics here, does it mean: "lock active"?
There was a problem hiding this comment.
would perhaps be better, but I think its also worth somethng to follow the method names already in use.
| Gauge.builder("locks.currentCount", ObjectLockerAdmin.JMX_INSTANCE, ObjectLockerAdmin::getCurrentCount) | ||
| .description("The current number of locked objects") | ||
| .register(registry); | ||
| Gauge.builder("locks.maxConcurrency", ObjectLockerAdmin.JMX_INSTANCE, ObjectLockerAdmin::getMaxConcurrency) |
There was a problem hiding this comment.
Same here lower case only. And what does max.concurrency mean?
There was a problem hiding this comment.
I put the meaning in the description.
2 participants
No description provided.