Conversation
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
=========================================
Coverage ? 32.67%
Complexity ? 982
=========================================
Files ? 275
Lines ? 9613
Branches ? 1115
=========================================
Hits ? 3141
Misses ? 6125
Partials ? 347 Continue to review full report at Codecov.
|
vpro-shared-test/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.hamcrest</groupId> | ||
| <artifactId>hamcrest-all</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
It seems illogical to add dependencies to vpro-shared-test if those are not used in the module itself.
As far as i can see the new module does not use anything from vpro-shared-test either, just using it's transitive dependencies.
There was a problem hiding this comment.
See my commit on this branch.
There was a problem hiding this comment.
Well I disagree, but will move it. Shared test can prevent down stream modules from the need to manage their own test dependencies. Hamcrest all is very general generic test resource. You probably want to use this on many locations.
8920388 to
44ca099
Compare
No description provided.