Skip to content

PIS-30 Shared health endpoint#5

Merged
Mindgamesnl merged 3 commits intomasterfrom
feature/PIS-30_Shared_health_endpoint
Oct 8, 2020
Merged

PIS-30 Shared health endpoint#5
Mindgamesnl merged 3 commits intomasterfrom
feature/PIS-30_Shared_health_endpoint

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 7, 2020

No description provided.

@ghost ghost requested a review from mihxil October 7, 2020 11:52
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@76cf841). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #5   +/-   ##
=========================================
  Coverage          ?   32.67%           
  Complexity        ?      982           
=========================================
  Files             ?      275           
  Lines             ?     9613           
  Branches          ?     1115           
=========================================
  Hits              ?     3141           
  Misses            ?     6125           
  Partials          ?      347           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76cf841...8920388. Read the comment docs.

<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest-all</artifactId>
</dependency>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems illogical to add dependencies to vpro-shared-test if those are not used in the module itself.

As far as i can see the new module does not use anything from vpro-shared-test either, just using it's transitive dependencies.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my commit on this branch.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I disagree, but will move it. Shared test can prevent down stream modules from the need to manage their own test dependencies. Hamcrest all is very general generic test resource. You probably want to use this on many locations.

@ghost ghost force-pushed the feature/PIS-30_Shared_health_endpoint branch from 8920388 to 44ca099 Compare October 8, 2020 08:33
@Mindgamesnl Mindgamesnl merged commit 565e444 into master Oct 8, 2020
@mihxil mihxil deleted the feature/PIS-30_Shared_health_endpoint branch April 8, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants