Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
============================================
+ Coverage 32.38% 32.60% +0.21%
- Complexity 974 987 +13
============================================
Files 276 276
Lines 9571 9577 +6
Branches 1109 1110 +1
============================================
+ Hits 3100 3123 +23
+ Misses 6126 6111 -15
+ Partials 345 343 -2
Continue to review full report at Codecov.
|
ghost
reviewed
Oct 23, 2020
| public class Copier implements Runnable, Closeable { | ||
|
|
||
| private boolean ready; | ||
| private Throwable errors; |
| @@ -142,9 +143,30 @@ public void waitFor() throws InterruptedException { | |||
| } | |||
|
|
|||
| public boolean isReady() { | |||
There was a problem hiding this comment.
Thie method should always throw IOException, let the caller handle it if wanted so. You always want to propagate the error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.