Capitalized CMAKE_BUILD_HOL value#664
Merged
MichaelRawson merged 1 commit intoMar 21, 2025
Merged
Conversation
Contributor
|
Thanks for this! I got bitten before. CI is just failing because we're not merging into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
The release notes say to use
CMAKE_BUILD_HOL=ONbutCMakeLists.txtonly supportsCMAKE_BUILD_HOL=On(note the lowercase "n") with a string comparison (here). In order to keep the values consistent with other CMake arguments I propose changing it toON.Thanks!
~Tyler