Skip to content

Fix TypeError resulting from lack of __rmul__ #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwcraig merged 1 commit into from
Feb 1, 2024
Merged

Fix TypeError resulting from lack of __rmul__ #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions vpython/cyvector.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,12 @@ cdef class vector(object):
return vector(self * other._x, self * other._y, self * other._z)
return NotImplemented

def __rmul__(self, other): # required to prevent y * x error
if isinstance(other, (float, int)):
return vector(self._x * other, self._y * other, self._z * other)

return NotImplemented

def __eq__(self,other):
if type(self) is vector and type(other) is vector:
return self.equals(other)
Expand Down