Fix build for recent Zig C naming changes#133
Merged
vrischmann merged 1 commit intovrischmann:masterfrom Sep 20, 2023
johnbcodes:fix-build
Merged
Fix build for recent Zig C naming changes#133vrischmann merged 1 commit intovrischmann:masterfrom johnbcodes:fix-build
vrischmann merged 1 commit intovrischmann:masterfrom
johnbcodes:fix-build
Conversation
1 task
Owner
|
Thanks ! I'm not sure if the mangling is expected here but I don't have the time to dig deeper right now, so this fix is fine for me. |
Contributor
Author
|
Looks like this isn't the end of this. In the latest build the Linux step has failures on the updated name: |
Owner
|
Maybe the name gets mangled differently based on the platform or something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Zig recently introduced a change to prevent C variable names conflicting with type names that I think is the reason compilation started to fail a few days ago. I don't understand the change enough to evaluate whether the result of
sqlite3_index_constraint_usagebeing mangled tostruct_sqlite3_index_constraint_usage_4is valid, but my change fixes the build.Checklist
No additional code so I didn't change the tests.
Note that I can't get tests to run on my local machine as discussed previously but I no longer get errors compiling.Update: With #134 all tests pass on Mac OS X with this change.