Open
Conversation
igdragoev
reviewed
Aug 3, 2018
Collaborator
igdragoev
left a comment
igdragoev
left a comment
There was a problem hiding this comment.
I think that some files are missing. Can you please check that you have commited all the new files.
| { | ||
| private readonly ApplicantsSystemDbContext db; | ||
| private readonly IAdminUserService users; | ||
| private readonly IAdminApplicantService users; |
Collaborator
There was a problem hiding this comment.
I dont see IAdminApplicantService file. Maybe you didn't commit it?
Owner
Author
There was a problem hiding this comment.
I tried to change the existing project, but after migration the errors were many. That's why I created everything from beginning. Also I refactored my code and may be this is the reason
igdragoev
approved these changes
Aug 5, 2018
Collaborator
igdragoev
left a comment
igdragoev
left a comment
There was a problem hiding this comment.
Overal looks good.
Error handling is missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed Tables And Relationships