Merged
Conversation
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
133a1e7 to
2641d12
Compare
brunoabreu
approved these changes
Jul 22, 2020
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
379eefd to
93a9fc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
'aborted', not'abort').ServerResponse- if the request is aborted, the response stream will be destroyed and then calling stream.finish with a destroyed ServerResponse won't trigger the callback. I opened a issue on NodeJS and hopefully we will get this feature in the next major :D (stream.finished failing to detect a destroyed ServerResponse nodejs/node#34301 stream: finished on closed OutgoingMessage nodejs/node#34313), but for now I created a workaroundWhat problem is this solving?
We don't have metrics on spans and traces generation per service. This will help us to detect if a service is overflowing Jaeger.
Types of changes