This repository was archived by the owner on Apr 30, 2021. It is now read-only.
do not modify headers when converting request to string#40
Merged
vti merged 1 commit intovti:masterfrom Oct 25, 2016
plicease:to_string_modifies_headers
Merged
do not modify headers when converting request to string#40vti merged 1 commit intovti:masterfrom plicease:to_string_modifies_headers
vti merged 1 commit intovti:masterfrom
plicease:to_string_modifies_headers
Conversation
vti
pushed a commit
that referenced
this pull request
Mar 11, 2019
do not modify headers when converting request to string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when I printed the request out twice I got different results. Please consider this patch which will make sure that the header attribute is not modified on the request object. I have also included a test which demonstrates the bug.