feat(compiler-sfc): transform use href add no-inline query#12550
Closed
btea wants to merge 1 commit into
Closed
Conversation
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-ssr
@vue/compiler-sfc
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
|
I don't think Vue should be adding a Vite specific handling here. The issue would also happen in builds before, not only after that PR. I think users would be adding the query themselves instead. |
Contributor
Author
|
Handle this issue on vite-plugin-vue side, hence closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In vitejs/vite#18581, vite will automatically convert SVGs smaller than
assetsInlineLimitinto base64, Since loadingdata:in the use tag in SVG will result in an error, it is more reasonable to addno-inlinequery when vue converts the href value of the use tag. WDYT? @bluwyabout vitejs/vite-plugin-vue#490
refer https://developer.chrome.com/blog/migrate-way-from-data-urls-in-svg-use