Skip to content

fix(runtime-core): app.unmount() does not require any arguments. (close #2922) #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LinusBorg wants to merge 1 commit into from
Closed

fix(runtime-core): app.unmount() does not require any arguments. (close #2922) #2925

LinusBorg wants to merge 1 commit into from

Conversation

@LinusBorg
Copy link
Member

@LinusBorg LinusBorg commented Jan 1, 2021

close #2922

@LinusBorg LinusBorg changed the title fix(runtime-core): app.unmount() does not require any arguments. fix(runtime-core): app.unmount() does not require any arguments. (close #2922) Jan 1, 2021
@LinusBorg LinusBorg added 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. scope: types labels Jan 1, 2021
@github-actions
Copy link

github-actions bot commented Jan 1, 2021

Size report

Path Size
vue.global.prod.js 40.51 KB (0%)
runtime-dom.global.prod.js 26.83 KB (0%)
size-check.global.prod.js 16.21 KB (0%)

@LinusBorg
Copy link
Member Author

LinusBorg commented Jan 1, 2021

closing in favor of #2924

@LinusBorg LinusBorg closed this Jan 1, 2021
@posva posva deleted the linusborg/fix-unmount-type-issue-2922 branch January 4, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. scope: types

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Discrepancy between code and documentation (also header) of app.unmount

2 participants

@LinusBorg