feat: detect the theme storage key of vitepress#207
Closed
LoTwT wants to merge 9 commits intovuejs:mainfrom
Closed
feat: detect the theme storage key of vitepress#207LoTwT wants to merge 9 commits intovuejs:mainfrom
LoTwT wants to merge 9 commits intovuejs:mainfrom
Conversation
✅ Deploy Preview for vue-devtools-docs canceled.
|
|
Hi! I'm the It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃 |
Member
|
You should rebase main branch to fix the conflicts |
b174a4f to
67c991f
Compare
alexzhang1030
approved these changes
Mar 11, 2024
songjianet
approved these changes
Mar 13, 2024
Member
|
Thanks for the PR, but I think it's too special and out of scope for the devtools. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
description
This PR is to close #202.
It detects the theme storage key
vitepress-theme-appearance. If the key is used in the local storage, it will be passed touseColorMode.question
Should the default key
vueuse-color-schemebe synchronized with thevitepress-theme-appearancein a vitepress project?