Add VueSchool Summer Sale banner #1082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.isSidebarOpen = false | ||
| }) | ||
| this.showTopBanner = !localStorage.getItem('VS_SUMMER_BANNER_CLOSED') |
Contributor
There was a problem hiding this comment.
It's not a blocker but it might be nice to have a check against Date.now() here too, so that the banner automatically disappears when the offer is over.
I'm primarily thinking about the translation repos, which are often a bit behind the main docs and can end up showing these banners for a long time after the offer has finished.
This was referenced Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a banner on top of vuejs.org to inform users about Vue School’s Summer Sale promotion.
The banner is closable and opens Vue School's Summer Sale promo page in a new tab. The banner will not reappear if a user has closed it (stored in local storage).
We’ve based the promotion on a previously used banner.
Click here to see screenshots of the banner.