docs (#18): add deployment page #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edison1105
approved these changes
Sep 17, 2020
bencodezen
commented
Oct 23, 2020
bencodezen
force-pushed
the
docs/18-add-deployment-page
branch
from
7d45ef0 to
958d79a
Compare
Member
Author
|
@phanan @NataliaTepluhina - Would love your review when you have a moment! |
skirtles-code
suggested changes
Oct 24, 2020
Contributor
skirtles-code
left a comment
skirtles-code
left a comment
There was a problem hiding this comment.
This isn't a subject I know much about but I've provided what little feedback I can.
sdras
requested changes
Oct 31, 2020
Member
sdras
left a comment
sdras
left a comment
There was a problem hiding this comment.
Minor changes here and there, but really close! @skirtles-code gave a great foundation of the review here
sdras
reviewed
Oct 31, 2020
sdras
reviewed
Oct 31, 2020
sdras
reviewed
Oct 31, 2020
sdras
approved these changes
Oct 31, 2020
Member
|
Great job @bencodezen and @skirtles-code! |
nick-lai
pushed a commit
to nick-lai/docs-next
that referenced
this pull request
Dec 2, 2020
* docs (#18): add deployment page * docs: remove named file * docs: fix app call * Update src/guide/tooling/deployment.md * Update src/guide/tooling/deployment.md * Update src/guide/tooling/deployment.md * Update src/guide/tooling/deployment.md * Update src/guide/tooling/deployment.md * Update src/guide/tooling/deployment.md * Update src/guide/tooling/deployment.md * remove Webpack 3 details Co-authored-by: Sarah Drasner <sarah.drasner@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a copy and paste from the v2 docs. As far as I'm aware, I don't think anything major has changed CLI wise from v2 to v3. Let me know if I missed anything @sodatea!
P.S. Feel free to add any other reviewers who might know more about this section.
Netlify Preview