#1888: adding stubbing for keep-alive#1889
Merged
lmiller1990 merged 1 commit intovuejs:mainfrom Dec 2, 2022
Merged
Conversation
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cexbrayat
approved these changes
Nov 28, 2022
Member
cexbrayat
left a comment
cexbrayat
left a comment
There was a problem hiding this comment.
LGTM thanks 👍
I added a question for the other reviewers about supporting KeepAlive: true
| } | ||
|
|
||
| // stub keep-alive by default via config.global.stubs | ||
| if ((type as any) === KeepAlive && 'keep-alive' in stubs) { |
Member
There was a problem hiding this comment.
maybe we should support KeepAlive: true as well?
Member
There was a problem hiding this comment.
nit: we could also use isKeepAlive instead of (type as any) === KeepAlive (and do the same for Teleport)
Member
There was a problem hiding this comment.
Maybe we just push this commit on behalf of the original author and ship this?
This was referenced Dec 2, 2022
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's very simple, the implementation is basically similar to what was done for
Teleport, changing the rendering of children forKeepAliveto a function.