fix(Carousel): intercept shift+wheel for discrete slide navigation#197
Merged
Conversation
Chrome's scroll-snap-type: mandatory absorbs each shift+wheel tick, making fast or direction-changing scrolls feel ignored. Intercept the event when Shift is held, preventDefault, and step next/prev with a 300ms throttle so one wheel tick moves exactly one slide. Closes #193
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wheelevents onCarouselViewportonly whenShiftis held, callpreventDefault, and stepnext()/prev()with a 300ms throttle.shiftKeyis false.Context
Chrome's
scroll-snap-type: x mandatoryresists fast, continuous shift+wheel input: each tick gets absorbed by the snap, so rapid or direction-changing scrolls feel sluggish or get swallowed entirely. The same behavior is reproducible on MDN's reference scroll-snap carousel. Firefox is mostly fluid.By bypassing the native wheel→scroll→snap pipeline for shift+wheel specifically and driving slide selection imperatively, one wheel tick = one slide, reliably.
Closes #193