feat: move serialization out of the payload package #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad serialization logic. This change introduces a design document that details the approach for replacing string-based user messages with structured request objects. This will decouple message formatting from the calling code and move serialization logic into provider-specific implementations.
This change updates the llm.provider interface and associated functions to accept structured request payloads instead of pre-formatted strings. This is the next step in refactoring the serialization logic out of calling packages and into the provider-specific implementations. Placeholders are used in the provider implementations to ensure the code compiles, with the actual serialization logic to be added in a subsequent change.
This commit refactors the way user messages are constructed and passed to LLM providers. Previously, the user message string was built in the and packages. This created a tight coupling between the calling code and the specific prompt format expected by the LLM. With this change, the responsibility of serializing the request data into a user message is moved to the individual LLM provider implementations ( and ). This is achieved by introducing new request structs in the package, which are then passed to the providers. This refactoring improves the separation of concerns, making the code more modular and easier to maintain and extend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28.