Skip to content

Add project Nutbox Blockchain#535

Closed
tolak wants to merge 2 commits intow3f:masterfrom
nutbox-dao:master
Closed

Add project Nutbox Blockchain#535
tolak wants to merge 2 commits intow3f:masterfrom
nutbox-dao:master

Conversation

@tolak
Copy link

@tolak tolak commented Jul 27, 2021

Project Abstract

Please provide a brief description of your project here summarising key points (1-2 paragraphs).

If your application is a follow-up to a previous grant, please mention which one in the first line of the abstract and include a link to previous pull requests if applicable.

Application Checklist

  • The application template has been copied, renamed ( project_name.md) and updated.
  • The total funding amount of the project is below USD $30k for first-time grant applications and $100k for follow-up ones.
  • A BTC or Ethereum (DAI/USDT) address for the payment of the milestones is provided inside the application.
  • I have read and acknowledged the terms and conditions.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted.

@tolak tolak mentioned this pull request Jul 27, 2021
7 tasks
Copy link
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updated application. As far as I know, there isn’t yet a “Substrate v4”. Also we usually don’t support deployment, monitoring or hosting (regarding the Nutbox Chain deliverable), so feel free to remove this part. Could you provide more information about the account and content pallets? What functionality will you implement? Also in case you are interested in open sourcing the faucet, we would also be interested in supporting this part as well.

@Noc2 Noc2 added the changes requested The team needs to clarify a few things first. label Jul 27, 2021
@mmagician
Copy link
Contributor

I won't support your project in its current state. I have the impression that there hasn't been much effort put into investigating the substrate stack nor into making an application, for the following reasons:

  1. As @Noc2 mentioned, there's no such thing as v4 now.
  2. Your project overview is the same text copied 3 times.
  3. Milestone 3 about ink! integration seems to just be including a contracts pallet. This would not provide any new value to the system, but rather paying you to follow the tutorials for including the pallet in your runtime.
  4. "Milestone 2, Nutbox Chain" or "M4, Asset Transfer" deliverables also bring nothing new, all these features are already available and plug-and-play in substrate.

Furthermore, you mention "storage proof validation" without providing any explanation of how you plan do achieve this, which is a non-trivial problem in the space.

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2021

CLA assistant check
All committers have signed the CLA.

@tolak
Copy link
Author

tolak commented Jul 30, 2021

@Noc2 @mmagician Hi, sorry for the late reply, i have updated the proposal, and thanks for your advises, there are some explanation about what you concerns:

there isn’t yet a “Substrate v4”.

Yes, we know that currently substrate is on v3, and i heard from others(not official) that v4 is comming soon, maybe it's not correct, but i think this is not so much important, we will use latest master branch during development.

Your project overview is the same text copied 3 times.

I am very sorry for the stupid mistake, because i copied those lines from other place, i should have a dobule review. The right content already been updated.

Milestone 3 about ink! integration seems to just be including a contracts pallet. This would not provide any new value to the system, but rather paying you to follow the tutorials for including the pallet in your runtime.

Yeah, it is easy if we just integrate ink module into our runtime. In our scenario we need read/write runtime from contract and verify if a image/video is exist with substrate offchain worker. So this would be the hard part we gonna to do. Thanks for substrate developers, dispatch call to runtime currently supported, see here. Besides, we would provide several contract templates to help our developers and communities build their DApps easily.

"Milestone 2, Nutbox Chain" or "M4, Asset Transfer" deliverables also bring nothing new, all these features are already available and plug-and-play in substrate.

There was a misunderstanding between us, sorry i haven't explained clearly in the document. The **Asset Transfer ** here is not transfer of balance-pallet, but a currency implementation by ourselves. It may be something like orml implemented by Acala. As i know, we have no token standards like ERC20 in polkadot ecosystem, i saw some discussion in element channel but nothing got so far, so we may implement by ourself or just use orml's.

The last one storage proof validation is the stuff that we need verify some offchain data(images/videos) saved in CDN or IPFS. We will verify them in offchain worker with the saved hash in runtime storage.

@mmagician
Copy link
Contributor

I'm sorry but your application is still missing details. Just as an example, it's not clear what you mean by:

The pob-pallet would implement the PoB incentive algorithm:
1) NUT and NP conversion.
2) Reward computing.
3) rewards distribution

Regarding ink! integration, there's no mention of "In our scenario we need read/write runtime from contract and verify if a image/video is exist with substrate offchain worker."


We would provide several contract templates to help developer and communities, e.g. Ink contract implementation for ERC20/ERC721/ERC1551

Are you aware of the examples provided in the ink! repo itself? It doesn't seem like your proposal would bring anything new.


Is there any reason you would want to implement your own currencies, over using the existing ones as you pointed out?


Lastly, your description of storage proof couldn't be more vague:

The last one storage proof validation is the stuff that we need verify some offchain data(images/videos) saved in CDN or IPFS. We will verify them in offchain worker with the saved hash in runtime storage.

@mmagician mmagician added the details missing Not enough technical details. label Aug 2, 2021
@mmagician mmagician self-assigned this Aug 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

Thank you for submitting a grant application.

We've assessed your submission and have found that it requires a higher level of technical detail in order to be considered for review. We encourage you to expand on it by providing a more precise specification/technical details. The section on project details in the application template is a good reference as to what type of information we expect applicants to provide, and these category-specific requirements contain more precise guidelines depending on what type of software you're building.

An area of the application that we often find to be insufficiently elaborated are the milestone deliverables. At a minimum, please indicate what languages/technologies you will be using to implement each deliverable, and provide a technical summary of its expected functionality. Note that deliverables should be tangible, reusable by other teams and in most cases not already present in the ecosystem. If they are, you will need to provide a comparison to existing implementations and explain why it makes sense to fund your approach. Also see our FAQ for a breakdown of what we fund and what we don't.

Let us know as soon as you're done with your changes, and we'll give your application another look!

@mmagician
Copy link
Contributor

Closing due to inactivity and missing details. Feel free to re-open the application with a more complete proposal.

@mmagician mmagician closed this Aug 11, 2021
@tolak
Copy link
Author

tolak commented Aug 11, 2021

@mmagician Thanks, we are preparing add more details into the proposal, would ask reopen this PR once it gets ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes requested The team needs to clarify a few things first. details missing Not enough technical details.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants