Re-ordered the logging to use the module namespace to segregate itself #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@sayanchowdhury here is what I was thinking about the re-working of the logging. I put in an example one on line 26 to show how we could partition out and separately log pieces if we or our users want to but by default everything would roll up. I also put it in the yaml format for readability. it's ultimately a python dict but I think for this kind of data structure yaml is easier for a dev or admin to read. Please let me know your thoughts |
slick666
force-pushed
the
logging_rework
branch
from
21ecda7 to
b6a7d35
Compare
Added a TODO to a hanging comment
slick666
force-pushed
the
logging_rework
branch
from
b6a7d35 to
a04ee72
Compare
slick666
force-pushed
the
logging_rework
branch
from
fe64739 to
0041986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a TODO to a hanging comment