Add radd, rsub and rmul#31
Merged
wadetb merged 1 commit intowadetb:masterfrom Jul 31, 2020
Merged
Conversation
Owner
|
Thanks for the PR- in the future please try to add tests, to confirm (at least limited) numpy compatibility. |
Contributor
Author
|
Sounds good! This was just something really quick that I needed for my project. Also I found that the add/mul/div implementations don't work well in the current master. Something about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a supplement PR to #29.
This PR adds the
rversions of__add__,__sub__and__mul__so that pre-(add/sub/mul) by a scalar works.