docs(workflow): correct hash-sync gate description#12
Merged
walkindude merged 1 commit intomasterfrom Apr 26, 2026
Merged
Conversation
The security comment claimed the job gated on `github.actor`, but the `if:` condition correctly checks `github.event.pull_request.user.login`. Updates the comment to match the code, with the rationale (the `@dependabot rebase` failure mode where actor becomes the human commenter) inline. Also corrects the loop-protection bullet: the reason re-pushes don't re-trigger this workflow is GITHUB_TOKEN's no-retrigger rule, not the actor flipping to github-actions[bot]. Comments-only; no behaviour change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dependabot-nix-hash-sync.ymlclaimed the job gated ongithub.actor, but theif:condition correctly checksgithub.event.pull_request.user.login. Comment now matches code.pull_request.user.loginovergithub.actor: the actor becomes the human commenter when someone runs@dependabot rebase, which would silently break the gate and let unauthorized writes slip throughpull_request_target's elevated permissions.Comments-only. No behaviour change.
Test plan
git diffshows only comment lines change