Skip to content

Merge crf aaf#1

Open
walkiry wants to merge 55 commits intoreviews/merge-crf-aaffrom
merge-crf-aaf
Open

Merge crf aaf#1
walkiry wants to merge 55 commits intoreviews/merge-crf-aaffrom
merge-crf-aaf

Conversation

@walkiry
Copy link
Copy Markdown
Owner

@walkiry walkiry commented Nov 2, 2020

No description provided.

Fabian Braun added 30 commits August 30, 2017 17:47
…ork audiomaps to enable CRF connection management!
…ed setting of clock source. TODO: Make Media clock server use the correct buffer!
Copy link
Copy Markdown
Owner Author

@walkiry walkiry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fabra Please check and adapt

@@ -1,4 +1,4 @@
#define AVB_1722_1_ENTITY_NAME_STRING "xCORE-200 MC Audio"
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here should be using the @varname@ format to change it at configure time

@@ -1,4 +1,4 @@
#define AVB_1722_1_ENTITY_NAME_STRING "xCORE-200 MC Audio"
#define AVB_1722_1_ENTITY_NAME_STRING "xCORE-200 Milan"
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here should be using the @varname@ format to change it at configure time / Same as the previous comment

#define AEM_GENERATE_DESCRIPTORS_ON_FLY 0
#define AVB_1722_1_AEM_ENABLED 1
#define AVB_ENABLE_1722_1 1

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a configure fine h.in to generate at configure time

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like:

#define AEM_GENERATE_DESCRIPTORS_ON_FLY @@AEM_GENERATE_DESCRIPTORS_ON_FLY@@
#define AVB_1722_1_AEM_ENABLED @@AVB_1722_1_AEM_ENABLED@@
#define AVB_ENABLE_1722_1 @@AVB_ENABLE_1722_1@@


/** Use 61883-6 audio format for 1722 streams */
#define AVB_1722_FORMAT_61883_6 1
#define AVB_1722_FORMAT_AAF 1
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a configure fine h.in to generate at configure time (e.g see previous example)

null,
c_listener_ctl[0],
AVB_NUM_SINKS,
2, /* 1 Audio + 1 CRF*/
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a configure fine h.in to generate at configure time (e.g see previous example)

Comment thread lib_tsn/src/srp/avb_srp.c
#define AVB_STREAM_TABLE_ENTRIES (AVB_NUM_SOURCES+AVB_NUM_SINKS+1+4)//+1 CRF Stream
#else
#define AVB_STREAM_TABLE_ENTRIES (8+AVB_NUM_SOURCES+AVB_NUM_SINKS+4)
#define AVB_STREAM_TABLE_ENTRIES (8+AVB_NUM_SOURCES+AVB_NUM_SINKS+1+4)//+1 CRF Stream
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create specific defined / or get the value from a context

Comment thread lib_tsn/src/srp/avb_srp.c
}

for (int i=0; i < AVB_NUM_SINKS; i++)
for (int i=0; i < AVB_NUM_SINKS+1; i++)//+1 CRF Stream
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create specific defined / or get the value from a context


struct output_finfo {
unsigned int *unsafe p_buffer[AVB_NUM_MEDIA_OUTPUTS];
unsigned int *unsafe p_buffer[AVB_NUM_MEDIA_OUTPUTS+1]; // +1 for CRF
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create specific defined / or get the value from a context


#ifndef AVB_1722_1_MAX_LISTENERS
#define AVB_1722_1_MAX_LISTENERS AVB_NUM_SINKS
#define AVB_1722_1_MAX_LISTENERS (AVB_NUM_SINKS+1) //+1 CRF Stream
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create specific defined / or get the value from a context


#ifndef AVB_1722_1_ADP_LISTENER_STREAM_SINKS
#define AVB_1722_1_ADP_LISTENER_STREAM_SINKS AVB_NUM_SINKS
#define AVB_1722_1_ADP_LISTENER_STREAM_SINKS (AVB_NUM_SINKS+1) //+1 CRF Stream
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create specific defined / or get the value from a context

@walkiry walkiry assigned walkiry and unassigned walkiry Nov 2, 2020
static unsigned long long calculate_wordlen(unsigned int sample_rate) {
const unsigned long long nanoseconds = (100000000LL << WORDLEN_FRACTIONAL_BITS);
const unsigned long long nanoseconds = (100000000LL << WORDLEN_FRACTIONAL_BITS); // 100000000 ticks per seconds for a 100MHz clock?
/* Calculate what master clock we should be using */
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming back to the master version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants