Optimizations Worker.php #1070
Merged
Optimizations Worker.php #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Null coalescing assignment operator (PHP 7.4) First check if logFile is 'dev/null' and later check if is_file(), so we use one stat less if not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Null coalescing assignment operator (PHP 7.4)
First check if
$logFile !== '/dev/null'and later check ifis_file(), so we use one stat less if not necessary and it's faster.PD: perhaps it's better if the default is
$logFile = '/dev/null'EDIT: I see that you changed
??=toempty()in Commit 43f9aadInitially I only wanted to change the if validation, and later changed to
??=that by default are alwaysnull, but you had change it for something.