Update shipped php.ini with php-production.ini from PHP 8.1 #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yguedidi
reviewed
Mar 10, 2024
Contributor
yguedidi
left a comment
yguedidi
left a comment
There was a problem hiding this comment.
were there any customization made before that should be preserved?
Member
Author
|
@yguedidi I kept customizations :) |
yguedidi
requested changes
Mar 10, 2024
| ; http://php.net/session.gc-probability | ||
| session.gc_probability = 0 | ||
| ; https://php.net/session.gc-probability | ||
| session.gc_probability = 1 |
Member
Author
There was a problem hiding this comment.
It is overridden by Symfony anyway, see https://symfony.com/doc/5.x/session.html#configuring-garbage-collection
However, some operating systems (e.g. Debian) do their own session handling and set the session.gc_probability variable to 0 to stop PHP doing garbage collection. That's why Symfony now overwrites this value to 1.
yguedidi
approved these changes
Mar 11, 2024
Signed-off-by: Kevin Decherf <kevin@kdecherf.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.