Skip to content

Unnecessarily passing cleartext URLs of all pages visited to server #204

@00dani

Description

@00dani

The "Indicate if page already saved" option is expected to make requests to your Wallabag server for every URL you visit, so it can check whether that URL is already saved. However, it currently uses the url query parameter to pass these URLs up as cleartext, and it doesn't need to.

The /api/entries/exists endpoint can instead be passed a hashed_url parameter, which is the SHA-1 hash of a URL and can also indicate whether a URL matching that hash exists on the server. Wallabagger should use this parameter instead, to avoid potentially leaking every URL you ever visit.

I don't know which versions of Wallabag support the hashed_url parameter, so it may be necessary to maintain support for cleartext checks as well. But making hashed_url available as an alternative option is certainly viable.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions