Sourcery Starbot ⭐ refactored wallies/deadpool #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceryAI
commented
Jul 21, 2023
| self.pid_callback(self._pid) | ||
| except Exception: # pragma: no cover | ||
| logger.exception(f"Error calling pid_callback") | ||
| logger.exception("Error calling pid_callback") |
Author
There was a problem hiding this comment.
Function Future.pid refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
| self.running_jobs.get_nowait() | ||
| except Empty: # pragma: no cover | ||
| logger.warning(f"Weird error, did not expect running jobs to be empty") | ||
| logger.warning("Weird error, did not expect running jobs to be empty") |
Author
There was a problem hiding this comment.
Function Deadpool.run_process refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
| initializer(*initargs) | ||
| except: | ||
| logger.exception(f"Initializer failed") | ||
| logger.exception("Initializer failed") |
Author
There was a problem hiding this comment.
Function raw_runner refactored with the following changes:
- Replace f-string with no interpolated values with string [×2] (
remove-redundant-fstring)
|
|
||
| def test_abc(): | ||
| assert 1 == 1 | ||
| pass |
Author
There was a problem hiding this comment.
Function test_abc refactored with the following changes:
- Remove
assert Truestatements (remove-assert-true) - Simplify x == x -> True and x != x -> False (
equality-identity)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run: