Remove legacy --rustc-quit-on-rmeta codepath from process_wrapper#3
Merged
Conversation
The old pipelining approach had the process_wrapper kill rustc after it wrote the .rmeta file, detected via an artifact JSON message with "emit": "metadata". This is no longer needed: rlib/lib types now use -Zno-codegen (hollow rlib), and non-rlib types with IDE metadata use --emit=dep-info,metadata which causes rustc to exit naturally. Remove --rustc-quit-on-rmeta flag parsing from options.rs, the stop_on_rmeta_completion function and RustcMessage::Emit variant from rustc.rs, the kill logic and quit_on_rmeta threading through process_line in main.rs, and the Terminate variant from LineOutput in output.rs (along with its match arm in process_output). Delete the test infrastructure that exercised the kill path: fake_rustc.rs (a stub rustc that emitted artifact JSON messages) and rustc_quit_on_rmeta.rs (the integration test for --rustc-quit-on-rmeta), along with their BUILD targets.
walter-zeromatter
force-pushed
the
user/wgray/pipelining
branch
from
d5b9921 to
0229d2a
Compare
walter-zeromatter
pushed a commit
that referenced
this pull request
Mar 6, 2026
…#3) * 0 * Add rust analyzer test coverage
walter-zeromatter
pushed a commit
that referenced
this pull request
Mar 6, 2026
…#3) * 0 * Add rust analyzer test coverage
walter-zeromatter
pushed a commit
that referenced
this pull request
Mar 17, 2026
…#3) * 0 * Add rust analyzer test coverage
walter-zeromatter
pushed a commit
that referenced
this pull request
Apr 3, 2026
…#3) * 0 * Add rust analyzer test coverage
walter-zeromatter
pushed a commit
that referenced
this pull request
Apr 15, 2026
…#3) * 0 * Add rust analyzer test coverage
walter-zeromatter
pushed a commit
that referenced
this pull request
Apr 17, 2026
…#3) * 0 * Add rust analyzer test coverage
walter-zeromatter
pushed a commit
that referenced
this pull request
May 8, 2026
…#3) * 0 * Add rust analyzer test coverage
walter-zeromatter
pushed a commit
that referenced
this pull request
May 19, 2026
…#3) * 0 * Add rust analyzer test coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old pipelining approach had the process_wrapper kill rustc after it wrote the .rmeta file, detected via an artifact JSON message with "emit": "metadata". This is no longer needed: rlib/lib types now use -Zno-codegen (hollow rlib), and non-rlib types with IDE metadata use --emit=dep-info,metadata which causes rustc to exit naturally.
Remove --rustc-quit-on-rmeta flag parsing from options.rs, the stop_on_rmeta_completion function and RustcMessage::Emit variant from rustc.rs, the kill logic and quit_on_rmeta threading through process_line in main.rs, and the Terminate variant from LineOutput in output.rs (along with its match arm in process_output).
Delete the test infrastructure that exercised the kill path: fake_rustc.rs (a stub rustc that emitted artifact JSON messages) and rustc_quit_on_rmeta.rs (the integration test for --rustc-quit-on-rmeta), along with their BUILD targets.