Remove quotes from stacktrace to work better with mysqldumpslow#6
Merged
Remove quotes from stacktrace to work better with mysqldumpslow#6
Conversation
hsource
added a commit
that referenced
this pull request
Jun 15, 2024
hsource
added a commit
that referenced
this pull request
Jun 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After dumpling slow query logs with our stacktraces using the
mysqldumpslowshell script that comes with MySQL/MariaDB, the stacktraces all get truncated to/* stacktrace='S' */which isn't very useful.Fix
Just don't surround the stacktraces with a single quote.
Testing
Ran
yarn add wanderlog/sqlcommenter-sequelize#harry-quotesand then ran thedb/index.test.tstest file and verified the output included the stacktrace: