Small cloud mode fixes.#10483
Merged
Merged
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR disables NLD behavior for cloud mode v2 and adds sticky selections for cloud mode host, harness, harness model, and auth secret choices.
Concerns
- The sticky host restore is overwritten during cloud input construction for users with a workspace/env default host, so a saved Warp/default-host choice does not actually persist.
- Auth secrets created through the FTUX flow are not written to
last_selected_auth_secret; only later dropdown selections are persisted, so a newly created key is lost on the next cloud-mode pane unless the user reselects it. - Model restore should also retry after harness availability changes so cold-cache sessions can apply the saved model once model metadata arrives.
Verdict
Found: 0 critical, 2 important, 1 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| selected, | ||
| default_host: None, | ||
| }; | ||
| // Restore the last selected host from settings. |
Contributor
There was a problem hiding this comment.
Input::new calls set_default_host and seeds worker_host from the workspace/env default, so a persisted warp selection is immediately overwritten for users with a default host. Move the restore/worker_host sync after default-host initialization or make set_default_host preserve an explicit saved selection.
| .get(harness.config_name()) | ||
| .cloned(); | ||
| if let Some(saved_id) = saved_id { | ||
| if HarnessAvailabilityModel::as_ref(ctx) |
Contributor
There was a problem hiding this comment.
💡 [SUGGESTION] Saved models are only restored when models_for is already populated; if harness availability arrives after construction, the HarnessAvailabilityEvent::Changed handler refreshes without retrying restore. Call maybe_restore_harness_model_from_settings from that handler before refreshing so cold-cache sessions keep the sticky model.
liliwilson
approved these changes
May 8, 2026
3 tasks
Co-Authored-By: Oz <oz-agent@warp.dev> Co-Authored-By: Abhishek Pandya <40919306+abhishekp106@users.noreply.github.com>
abhishekp106
force-pushed
the
abhishek/cloud_mode_fixes
branch
from
629c2e9 to
6437a90
Compare
cephalonaut
pushed a commit
that referenced
this pull request
May 12, 2026
## Description <!-- Please remember to add your design buddy onto the PR for review, if it contains any UI changes! --> Various small cloud mode v2 fixes: - disables NLD so the cursor color doesn't flicker (NLD has no use in cloud mode) - have the best match item when searching for models be selected - make host, harness, model selection, auth secret sticky ## Testing <!-- How did you test this change? What automated tests did you add? If you didn't add any new tests, what's your justification for not adding any? Manual testing is required for changes that can be manually tested, and almost all changes can be manually tested. If your change can be manually tested, please include screenshots or a screen recording that show it working end to end. You can run the app locally using `./script/run` - see WARP.md for more details on how to get set up. --> - [x] I have manually tested my changes locally with `./script/run` ### Screenshots / Videos <!-- Attach screenshots or a short video demonstrating the change, where appropriate. Remove this section if it is not relevant to your PR. --> https://www.loom.com/share/cc9e7f32cc754f16ae6395a25f6425e1 ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode --------- Co-authored-by: Oz <oz-agent@warp.dev>
cephalonaut
pushed a commit
that referenced
this pull request
May 12, 2026
## Description <!-- Please remember to add your design buddy onto the PR for review, if it contains any UI changes! --> Various small cloud mode v2 fixes: - disables NLD so the cursor color doesn't flicker (NLD has no use in cloud mode) - have the best match item when searching for models be selected - make host, harness, model selection, auth secret sticky ## Testing <!-- How did you test this change? What automated tests did you add? If you didn't add any new tests, what's your justification for not adding any? Manual testing is required for changes that can be manually tested, and almost all changes can be manually tested. If your change can be manually tested, please include screenshots or a screen recording that show it working end to end. You can run the app locally using `./script/run` - see WARP.md for more details on how to get set up. --> - [x] I have manually tested my changes locally with `./script/run` ### Screenshots / Videos <!-- Attach screenshots or a short video demonstrating the change, where appropriate. Remove this section if it is not relevant to your PR. --> https://www.loom.com/share/cc9e7f32cc754f16ae6395a25f6425e1 ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode --------- Co-authored-by: Oz <oz-agent@warp.dev>
lawsmd
pushed a commit
to lawsmd/cortex
that referenced
this pull request
May 22, 2026
## Description <!-- Please remember to add your design buddy onto the PR for review, if it contains any UI changes! --> Various small cloud mode v2 fixes: - disables NLD so the cursor color doesn't flicker (NLD has no use in cloud mode) - have the best match item when searching for models be selected - make host, harness, model selection, auth secret sticky ## Testing <!-- How did you test this change? What automated tests did you add? If you didn't add any new tests, what's your justification for not adding any? Manual testing is required for changes that can be manually tested, and almost all changes can be manually tested. If your change can be manually tested, please include screenshots or a screen recording that show it working end to end. You can run the app locally using `./script/run` - see WARP.md for more details on how to get set up. --> - [x] I have manually tested my changes locally with `./script/run` ### Screenshots / Videos <!-- Attach screenshots or a short video demonstrating the change, where appropriate. Remove this section if it is not relevant to your PR. --> https://www.loom.com/share/cc9e7f32cc754f16ae6395a25f6425e1 ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode --------- Co-authored-by: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Various small cloud mode v2 fixes:
Testing
./script/runScreenshots / Videos
https://www.loom.com/share/cc9e7f32cc754f16ae6395a25f6425e1
Agent Mode