Set cloud agent task context before setup#11533
Open
bnavetta wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
Contributor
There was a problem hiding this comment.
Overview
This PR moves ambient cloud-agent task context setup earlier in AgentDriverRunner::setup_and_run_driver and reuses a helper so early setup calls and driver error reporting can include the task ID header.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServerApi's ambient agent task ID immediately whenagent run --task-idstarts, before Warp Drive sync, metadata refresh, secrets/attachment fetches, cloud provider setup, or driver error reporting can fail.ServerApihas the task ID, existing header injection adds the cloud agent context automatically.This should fix a regression where early setup failures couldn't be reported to the server, since they didn't include cloud agent request metadata.
Validation
cargo check --manifest-path /workspace/warp/Cargo.toml -p warp --libpassed with existing warnings.rustfmt --edition 2021 --config-path /workspace/warp/.rustfmt.toml --check /workspace/warp/app/src/ai/agent_sdk/mod.rspassed.git -C /workspace/warp --no-pager diff --checkpassed.cargo nextest run --manifest-path /workspace/warp/Cargo.toml -p warp -E 'test(ambient_agent_headers_for_task_overrides_existing_cloud_agent_header)'was attempted but the test build was killed with SIGKILL; retrying withCARGO_BUILD_JOBS=1stalled near the end of compilingwarp(test)and was interrupted.Conversation: https://staging.warp.dev/conversation/231ac3b7-4202-44a7-9e0d-68370eebdde0
Run: https://oz.staging.warp.dev/runs/019e4f84-9b90-78ff-992c-c292c42dc194
This PR was generated with Oz.