Skip to content

Update handoff surfaces to allow for empty prompts (and auto-handoff on click)#11576

Open
harryalbert wants to merge 2 commits into
harry/empty-prompt-handoff-wire-contractfrom
harry/empty-prompt-handoff-local
Open

Update handoff surfaces to allow for empty prompts (and auto-handoff on click)#11576
harryalbert wants to merge 2 commits into
harry/empty-prompt-handoff-wire-contractfrom
harry/empty-prompt-handoff-local

Conversation

@harryalbert
Copy link
Copy Markdown
Contributor

@harryalbert harryalbert commented May 22, 2026

Description

Building off of the changes from the PR below this one in the stack, we now want to change all of the client handoff surfaces to allow for handing off without a prompt (and to take advantage of this instant handoff flow).

Specifically, we change it so that:

  • clicking the handoff chip (when the prompt is empty) automatically kicks off handoff
    • if the conversation is in progress when handing off, a "continue" prompt is auto-inserted so the agent continues its work stream in the cloud
    • if the conversation has some snapshots to restore, a prompt is inserted to do snapshot restoration. Otherwise, we would skip snapshot restoration entirely (or do it without a user visible prompt)
    • if neither of these are true, we just handoff with no prompt
  • typing /handoff with no prompt also automatically kicks off handoff (with the same prompt semantics as above)
  • We listen for the new AmbientSetupPhaseEnded session sharing message from this PR to exit the environment setup phase, removing our dependency on a prompt event to do this.

Testing

  • I have manually tested my changes locally with ./script/run

Screenshots / Videos

https://www.loom.com/share/e748b81a3e22418f9e9836acf56c06c1

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@harryalbert harryalbert force-pushed the harry/empty-prompt-handoff-local branch from 1e1c849 to f940530 Compare May 26, 2026 19:22
@harryalbert harryalbert changed the title Add empty-prompt cloud handoff client behavior (Stage 2) Update handoff surfaces to allow for empty prompts (and auto-handoff on click) May 26, 2026
Comment thread Cargo.lock
[[package]]
name = "session-sharing-protocol"
version = "0.0.0"
source = "git+https://github.com/warpdotdev/session-sharing-protocol.git?rev=5a0ad6135809feee9da2e9efae8bd6b54b89172e#5a0ad6135809feee9da2e9efae8bd6b54b89172e"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update this once the session sharing proto is merged

@harryalbert harryalbert requested a review from zachbai May 26, 2026 19:41
@harryalbert harryalbert marked this pull request as ready for review May 26, 2026 19:41
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 26, 2026

@harryalbert

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR updates local-to-cloud handoff paths to support empty prompts, adds skip-initial-turn handling, and introduces the AmbientSetupPhaseEnded shared-session marker.

Concerns

  • Cargo.toml is still wired to a testing-only local session-sharing-protocol path dependency, which makes builds depend on an unpinned sibling checkout and must be reverted to a reviewed git revision before merge.

Security

  • The local path dependency is a supply-chain/reproducibility risk because the build can resolve whatever code is present outside the repository instead of the reviewed protocol revision.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Comment thread Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant