Update handoff surfaces to allow for empty prompts (and auto-handoff on click)#11576
Update handoff surfaces to allow for empty prompts (and auto-handoff on click)#11576harryalbert wants to merge 2 commits into
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c48a56f to
1e1c849
Compare
1e1c849 to
f940530
Compare
| [[package]] | ||
| name = "session-sharing-protocol" | ||
| version = "0.0.0" | ||
| source = "git+https://github.com/warpdotdev/session-sharing-protocol.git?rev=5a0ad6135809feee9da2e9efae8bd6b54b89172e#5a0ad6135809feee9da2e9efae8bd6b54b89172e" |
There was a problem hiding this comment.
I'll update this once the session sharing proto is merged
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR updates local-to-cloud handoff paths to support empty prompts, adds skip-initial-turn handling, and introduces the AmbientSetupPhaseEnded shared-session marker.
Concerns
Cargo.tomlis still wired to a testing-only localsession-sharing-protocolpath dependency, which makes builds depend on an unpinned sibling checkout and must be reverted to a reviewed git revision before merge.
Security
- The local path dependency is a supply-chain/reproducibility risk because the build can resolve whatever code is present outside the repository instead of the reviewed protocol revision.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz

Description
Building off of the changes from the PR below this one in the stack, we now want to change all of the client handoff surfaces to allow for handing off without a prompt (and to take advantage of this instant handoff flow).
Specifically, we change it so that:
AmbientSetupPhaseEndedsession sharing message from this PR to exit the environment setup phase, removing our dependency on a prompt event to do this.Testing
./script/runScreenshots / Videos
https://www.loom.com/share/e748b81a3e22418f9e9836acf56c06c1
Agent Mode