Don't require login to open file from URI#9300
Conversation
|
I'm starting a first review of this pull request. You can follow along in the session on Warp. I completed the review and posted feedback on this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR removes the login requirement from URI/file-opening flow so local files and path-based tab/window actions can work while logged out.
Concerns
- Removing the auth-state check leaves
AuthStateProviderunused inapp/src/uri/mod.rs, which will trip the repository's-D warningsclippy workflow unless the import is also removed.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| /// * For other files, open a new session at the parent directory path, then possibly execute the | ||
| /// file. | ||
| fn open_file(window_id: Option<WindowId>, path: PathBuf, ctx: &mut AppContext) { | ||
| let auth_state = AuthStateProvider::as_ref(ctx).get(); |
There was a problem hiding this comment.
AuthStateProvider imported but unused, so cargo clippy -- -D warnings will fail; remove the import too.
kevinchevalier
left a comment
kevinchevalier
left a comment
There was a problem hiding this comment.
Fix the import and it looks good.
2 participants
Description
This gate was added ~2 years ago to prevent some panic, but I confirmed the panic doesn't happen anymore. Warp no longer requires login, so we should support opening files in warp even when not logged in.
I noticed this while testing #9277
Testing
Tested locally. While logged out,
open "warplocal://action/new_tab?path=/Users/rolandhuang/warp"opens the tab in that directory correctly.Also tested with right click on file > open in WarpLocal while logged out works
While on the login screen, it just focuses the window.