Sync blocklist image extensions with is_binary_file

[anshul-garg27]

Description

Follow-up to #9395 in a different file. While auditing image-extension lists across the repo I found a third copy in is_supported_blocklist_image_source (app/src/ai/blocklist/block/view_impl/common.rs) that suffers from the exact same drift: it only matches jpg | jpeg | png | gif | webp | svg, missing .bmp, .tiff / .tif, and .ico. So inline references to local .bmp / .tiff / .ico images in agent block output fail the support check and don't render as the inline image — they silently fall back to plain text — even though the same files do route to the system viewer once #9395 lands.

-                "jpg" | "jpeg" | "png" | "gif" | "webp" | "svg"
+                "jpg" | "jpeg" | "png" | "gif" | "bmp" | "tiff" | "tif" | "webp" | "ico" | "svg"

The full picture, for context:

Location	What it does	Pre-fix
crates/warp_util/src/file_type.rs (is_binary_file)	Canonical binary-file extension list	9 image formats
app/src/util/openable_file_type.rs (is_supported_image_file)	Routes click-to-open to FileTarget::SystemGeneric	6 formats — fixed in #9395
This PR — app/src/ai/blocklist/block/view_impl/common.rs (is_supported_blocklist_image_source)	Gates inline rendering of agent block image references	6 formats
crates/warpui_core/src/platform/file_picker.rs (FileType::Image)	Theme-creator file-picker filter	3 formats — left for a separate PR; the right "what should be selectable as a theme background" set is more subjective

Testing

• Added is_supported_blocklist_image_source_covers_common_local_formats in common_tests.rs. Asserts every supported extension passes (10 cases), case-insensitivity (PHOTO.PNG, scan.TIFF), and that HTTP / HTTPS sources and non-image extensions still return false. Fails on master for the four new extensions, passes after the change.
• cargo fmt -p warp -- --check passes locally.
• Couldn't run cargo nextest locally because the Metal toolchain isn't installed (same caveat as Expand ~ in warp://action/new_tab?path= URLs #9277, Recognize .command files as shell scripts #9345, Also recognize .h++ as a C++ header extension #9346, Recognize .bmp, .tiff, .tif, and .ico as supported image files #9395) — relying on CI for the full clippy / nextest pass.

Related

• Recognize .bmp, .tiff, .tif, and .ico as supported image files #9395 — same fix for is_supported_image_file (file-open routing path).

Changelog Entries for Stable

CHANGELOG-BUG-FIX: Inline .bmp, .tiff / .tif, and .ico images in agent block output now render correctly instead of falling back to plain text.

[oz-for-oss]

@anshul-garg27

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I approved this pull request. No matching stakeholder was found for the changed files, so no human reviewers were requested.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR syncs the blocklist inline image support check with the common local image extensions handled elsewhere by adding bmp, tiff, tif, and ico, and adds targeted unit coverage for the accepted extensions, case-insensitivity, HTTP/HTTPS rejection, and non-image rejection.

Concerns

• No blocking correctness or security concerns found in the changed lines.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[captainsafia]

@zachbai Handing this over to you for review since you're list in the STAKEHOLDERS for blocklist. Feel free to delegate.

[anshul-garg27]

Update — also confirmed locally with cargo nextest:

Starting 1 test across 1 binary (3611 tests skipped)
    PASS [0.023s] (1/1) warp ai::blocklist::block::view_impl::common::tests::is_supported_blocklist_image_source_covers_common_local_formats
────────────
     Summary [0.025s] 1 test run: 1 passed, 3611 skipped

Command: cargo nextest run --features=gui -p warp -E 'test(is_supported_blocklist_image_source_covers_common_local_formats)'

[zachbai]

Thanks for the fix!