make sure Windows quake mode window is correctly sized and receives focus#9891
Merged
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
acarl005
commented
May 2, 2026
|
|
||
| impl WindowManager { | ||
| /// Returns the active Warp window. This will return an error if a different app's window is | ||
| /// active. |
Contributor
Author
There was a problem hiding this comment.
"This will return an error if a different app's window is active."
This bit is the crux of the issue. Added fn get_foreground_monitor to compensate for this behavior.
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR updates Windows window focus behavior and monitor selection so the hotkey/quake window can be sized against the foreground app's monitor and explicitly focused after being shown.
Concerns
- No blocking correctness or security concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
peicodes
approved these changes
May 3, 2026
wolverine2k
pushed a commit
to wolverine2k/warp
that referenced
this pull request
May 5, 2026
Leejaywell
pushed a commit
to Leejaywell/warp
that referenced
this pull request
May 5, 2026
Leejaywell
pushed a commit
to Leejaywell/warp
that referenced
this pull request
May 5, 2026
Leejaywell
added a commit
to Leejaywell/warp
that referenced
this pull request
May 5, 2026
Cherry-picked from upstream: - fix: highlight C++ header extensions (warpdotdev#9388) - Run executable shell scripts in the terminal (warpdotdev#9503) - Revert schema generator binary recompilation fix (warpdotdev#9676) - Remove stray backticks from Windows installer README (warpdotdev#9691) - Fix chord shortcuts on Windows non-Latin keyboard layouts (warpdotdev#9476) - Scroll output with Page Up/Down from prompt (warpdotdev#9624) - Respect Markdown Viewer setting for .md links in AI rules/facts panel (warpdotdev#9699) - fix: disable reset grid checks for restored blocks on Windows (warpdotdev#9987) - add RedirectionGuard=no to windows-installer.iss (warpdotdev#9863) - Windows quake mode window correctly sized (warpdotdev#9891) - fix: update rand to 0.9.4 (GHSA-cq8v-f236-94qc) (warpdotdev#10060) - Fix diff button when Show code review button toggle is off (warpdotdev#9600) - Fix freshly cloned repo stuck in loading state (warpdotdev#9998) - Fix terminal text selection not auto-scrolling when dragging (warpdotdev#9448) - Resolve conflict markers from 3f0ac51 and edac651
zerx-lab
pushed a commit
to zerx-lab/zap
that referenced
this pull request
May 8, 2026
…ocus (warpdotdev#9891) (cherry picked from commit c65ae25)
trungtai1805
pushed a commit
to trungtai1805/warp
that referenced
this pull request
May 9, 2026
1 task
lawsmd
pushed a commit
to lawsmd/cortex
that referenced
this pull request
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #6507
The problem was that the quake mode window would not receive focus and would be incorrectly sized if a different app had focus when the quake mode window was summoned.
Testing
Showing the quake mode window when a different app has focus now works.
Changelog Entries for Stable
CHANGELOG-BUG-FIX: [Windows] Fix hotkey window.