Skip to content

[Snyk] Fix for 2 vulnerabilities#136

Open
wasimakh2 wants to merge 1 commit intodevelopfrom
snyk-fix-1b5b3e8fabb02118d7db51d9478c4829
Open

[Snyk] Fix for 2 vulnerabilities#136
wasimakh2 wants to merge 1 commit intodevelopfrom
snyk-fix-1b5b3e8fabb02118d7db51d9478c4829

Conversation

@wasimakh2
Copy link
Owner

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • package.json
⚠️ Warning
Failed to update the package-lock.json, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Directory Traversal
SNYK-JS-TAR-15032660
  693  
medium severity Directory Traversal
SNYK-JS-TAR-15127355
  596  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Directory Traversal

Copilot AI review requested due to automatic review settings January 29, 2026 01:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This Snyk-generated PR addresses 2 directory traversal vulnerabilities (SNYK-JS-TAR-15032660 and SNYK-JS-TAR-15127355) in the tar dependency by upgrading two npm packages that have tar as a transitive dependency.

Changes:

  • Upgrade bcrypt from ^5.0.0 to ^5.0.1 (patch version bump)
  • Upgrade sharp from ^0.22.1 to ^0.26.0 (significant minor version jump spanning 4 releases)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"aws-sdk": "^2.735.0",
"bad-words": "^3.0.3",
"bcrypt": "^5.0.0",
"bcrypt": "^5.0.1",
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package-lock.json file was not updated by Snyk as indicated in the PR description warning. This PR only updates package.json, which means the actual dependency versions will not be locked and the security vulnerabilities will not be fully resolved. The package-lock.json must be updated manually before this PR can be merged to ensure the correct versions of bcrypt and sharp (and their transitive dependencies including tar) are installed.

Suggested change
"bcrypt": "^5.0.1",
"bcrypt": "5.0.1",

Copilot uses AI. Check for mistakes.
"redis": "^2.8.0",
"semver": "^5.7.1",
"sharp": "^0.22.1",
"sharp": "^0.26.0",
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sharp package is being upgraded from version 0.22.1 to 0.26.0, which is a significant jump spanning 4 minor versions (0.23, 0.24, 0.25, 0.26) over approximately one year. Sharp has had multiple breaking changes and API modifications between these versions. Before merging, it's important to:

  1. Test all image processing functionality, particularly avatar uploads, image resizing, and format conversions
  2. Review sharp's changelog for versions 0.23.0 through 0.26.0 for breaking changes
  3. Verify that the API usage patterns in the codebase (found in app/assets/server/assets.js, app/file-upload/server/lib/FileUpload.js, and server/routes/avatar/utils.js) remain compatible with version 0.26.0

Note: The code at server/routes/avatar/utils.js line 18 uses the deprecated new Buffer() constructor which may need updating for compatibility with newer sharp versions.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments