refactor: move Module and function_type helper to module.hpp#281
Merged
refactor: move Module and function_type helper to module.hpp#281
Conversation
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 35 36 +1
Lines 10045 10046 +1
=======================================
+ Hits 9877 9878 +1
Misses 168 168 |
chfast
reviewed
Apr 23, 2020
chfast
reviewed
Apr 23, 2020
Collaborator
chfast
left a comment
chfast
left a comment
There was a problem hiding this comment.
I think you should also move Module type here.
gumb0
force-pushed
the
function-type-helper
branch
from
056e201 to
a752ab1
Compare
gumb0
force-pushed
the
function-type-helper
branch
from
a752ab1 to
d569948
Compare
chfast
approved these changes
Apr 30, 2020
Collaborator
chfast
left a comment
chfast
left a comment
There was a problem hiding this comment.
Nice. Just you can squash "rename" and "make method" commits.
gumb0
force-pushed
the
function-type-helper
branch
2 times, most recently
from
5620629 to
aac8d2e
Compare
gumb0
changed the title
axic
approved these changes
May 8, 2020
This was referenced May 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for #267