Add Builtin LDA Electron-Proton Correlation Functionals #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wavefunction91
requested changes
May 2, 2024
Owner
wavefunction91
left a comment
wavefunction91
left a comment
There was a problem hiding this comment.
Still need to look at the unit tests more carefully, but this should be a good round of things to look at. I'll check out the tests tomorrow.
…it to automatically generate
wavefunction91
requested changes
May 3, 2024
Owner
wavefunction91
left a comment
wavefunction91
left a comment
There was a problem hiding this comment.
Small requests, other than that LGTM.
wavefunction91
requested changes
May 3, 2024
wavefunction91
requested changes
May 3, 2024
wavefunction91
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added LDA electron-proton correlation functionals and kernels using Builtin backend. These are for nuclear-electronic orbital DFT method.
The functionals include: EPC17-1, EPC17-2, EPC18-1, EPC18-2
This PR partially address #35 by first adding in the LDA epc functionals. The GGA epc functional (epc19) is in preparation and will be merged later.