Device UKS/GKS Implementation #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wavefunction91
requested changes
Nov 29, 2023
Owner
wavefunction91
left a comment
wavefunction91
left a comment
There was a problem hiding this comment.
Quick once over - this looks like a good start. Definitely want to get UKS GGA + unification of the RKS/UKS drivers (e.g. the local_work bits). Will do a more thorough review once its more complete!
src/xc_integrator/local_work_driver/device/cuda/kernels/uvvars.cu
Outdated
Show resolved
Hide resolved
src/xc_integrator/local_work_driver/device/cuda/kernels/uvvars.cu
Outdated
Show resolved
Hide resolved
src/xc_integrator/local_work_driver/device/cuda/kernels/uvvars.cu
Outdated
Show resolved
Hide resolved
src/xc_integrator/local_work_driver/device/local_device_work_driver.hpp
Outdated
Show resolved
Hide resolved
added 7 commits
November 30, 2023 13:37
… some overloaded funcs
mikovtun
commented
Dec 1, 2023
src/xc_integrator/replicated/device/shellbatched_replicated_xc_device_integrator_exc_vxc.hpp
Outdated
Show resolved
Hide resolved
src/xc_integrator/local_work_driver/device/cuda/kernels/uvvars.cu
Outdated
Show resolved
Hide resolved
src/xc_integrator/local_work_driver/device/cuda/kernels/zmat_vxc.cu
Outdated
Show resolved
Hide resolved
src/xc_integrator/local_work_driver/device/cuda/kernels/zmat_vxc.cu
Outdated
Show resolved
Hide resolved
src/xc_integrator/replicated/device/shellbatched_replicated_xc_device_integrator.hpp
Outdated
Show resolved
Hide resolved
src/xc_integrator/replicated/device/shellbatched_replicated_xc_device_integrator_exc_vxc.hpp
Outdated
Show resolved
Hide resolved
wavefunction91
changed the title
mikovtun
commented
Jul 9, 2024
Contributor
Author
|
|
wavefunction91
requested changes
Jul 30, 2024
Owner
wavefunction91
left a comment
wavefunction91
left a comment
There was a problem hiding this comment.
Add a screenshot / terminal output showing no performance degradation for Ubi DZ/PBE between current master and this PR + the misc minor changes noted, and this is g2g.
Sorry for the delay.
|
|
||
| if (mtemp > dtolsq) { | ||
| const double inv_mnorm = rsqrt(mtemp); | ||
| mnorm = 1./inv_mnorm; |
Owner
There was a problem hiding this comment.
For future note, this is likely the culprit for #134.
src/xc_integrator/replicated/device/incore_replicated_xc_device_integrator_exc_vxc.hpp
Outdated
Show resolved
Hide resolved
src/xc_integrator/shell_batched/shell_batched_replicated_xc_integrator_exc_grad.hpp
Outdated
Show resolved
Hide resolved
src/xc_integrator/shell_batched/shell_batched_replicated_xc_integrator_exx.hpp
Outdated
Show resolved
Hide resolved
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds device (CUDA) support for XC calculations with Unrestricted and Generalized Kohn-Sham references. LDA and GGA functionals are supported.