Skip to content

Comment and fix the routine for Gauss-Chebyshev quadrature of the 2nd kind #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wavefunction91 merged 1 commit into from
Jul 6, 2023
Merged

Comment and fix the routine for Gauss-Chebyshev quadrature of the 2nd kind #22

wavefunction91 merged 1 commit into from
Jul 6, 2023

Conversation

@susilehtola
Copy link
Collaborator

@susilehtola susilehtola commented Jul 6, 2023

Closes #20

wavefunction91
wavefunction91 approved these changes Jul 6, 2023
View reviewed changes
Copy link
Owner

@wavefunction91 wavefunction91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but it also needs a unit test. I'll add an issue to track.

@wavefunction91 wavefunction91 merged commit b4b1ae8 into wavefunction91:master Jul 6, 2023
@wavefunction91 wavefunction91 mentioned this pull request Jul 6, 2023
Closed
@susilehtola susilehtola deleted the fix_gausscheby2 branch July 6, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wavefunction91 wavefunction91 wavefunction91 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issues in gausscheby2

2 participants

@susilehtola @wavefunction91