Skip to content

Conversation

@susilehtola
Copy link
Collaborator

What's your take on automated formatting with clang-format?

I would like to reformat all files in a unified form with clang-format, which is used by many projects. You are of course free to decide the formatting style to use.

@wavefunction91
Copy link
Owner

I'm generally in favor of this, but I would prefer to add proper actions / hooks to automate the formatting. I've done this for MACIS

https://github.com/wavefunction91/MACIS/blob/master/.github/workflows/clang_format_lint.yaml

Also, I have a standard .clang-format that I like for these kinds of projects

https://github.com/wavefunction91/MACIS/blob/master/.clang-format

If you want to just update the format file for this PR, I can add the action. The permissions won't allow for new actions from external PRs.

@susilehtola
Copy link
Collaborator Author

Sure, done

@wavefunction91 wavefunction91 merged commit ddeaaa3 into wavefunction91:master Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants