Implement Ahrens-Beylkin quadrature on the sphere. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Looks like this still needs to be updated with |
Merged
susilehtola
force-pushed
the
ahrens_beylkin
branch
from
66944a0 to
f64289b
Compare
wavefunction91
requested changes
Jul 8, 2023
Owner
wavefunction91
left a comment
wavefunction91
left a comment
There was a problem hiding this comment.
As soon as the unit tests pass and the branch has been updated with master, this is g2g. Best to get it checked in to avoid potential conflicts later.
susilehtola
force-pushed
the
ahrens_beylkin
branch
3 times, most recently
from
bdf6cab to
26bfc76
Compare
wavefunction91
requested changes
Jul 9, 2023
Owner
wavefunction91
left a comment
wavefunction91
left a comment
There was a problem hiding this comment.
Other than the minor structural stuff, LGTM
sum up to 4 pi, while the Lebedev weights summed up to one, from now on include the 4 pi factor in the Lebedev quadratures as well, for consistency.
susilehtola
force-pushed
the
ahrens_beylkin
branch
from
26bfc76 to
8c3b2e3
Compare
wavefunction91
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8