Skip to content

Conversation

@finico
Copy link
Contributor

@finico finico commented Jul 8, 2019

No description provided.

tsigel
tsigel previously approved these changes Jul 9, 2019
@finico finico force-pushed the dexw-1911-hooks branch from e05b22c to 6cdb76d Compare July 10, 2019 07:56
const ns = $element.attr(nsAttr) || $element.closest(`[${nsAttr}]`).attr(nsAttr);
var $element = $(this);
var literal = $element.attr('w-i18n');
var ns = $element.attr(nsAttr) || $element.closest(`[${nsAttr}]`).attr(nsAttr);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es5

var $element = $(this);
var literal = $element.attr('w-i18n');
var ns = $element.attr(nsAttr) || $element.closest(`[${nsAttr}]`).attr(nsAttr);
console.log(`Namespace "${ns}", literal "${literal}"`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no es5

const origin = window.onerror || function () {
};
window.onerror = function (message: string, filename?: string, lineno?: number, colno?: number, error?: Error) {
const origin = window.onerror || function () { /* pass */ };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants