Skip to content

fix: let props_to_labels take properties from log line#11

Merged
simosho merged 1 commit intowaylay_mainfrom
WPPM-1211-align-severity-level-in-node-and-python-logs
Oct 4, 2023
Merged

fix: let props_to_labels take properties from log line#11
simosho merged 1 commit intowaylay_mainfrom
WPPM-1211-align-severity-level-in-node-and-python-logs

Conversation

@simosho
Copy link
Copy Markdown

@simosho simosho commented Oct 3, 2023 •
edited
Loading

  • validate with function-logger-py

@simosho simosho requested a review from a team as a code owner October 3, 2023 10:28
@simosho simosho force-pushed the WPPM-1211-align-severity-level-in-node-and-python-logs branch from 7e5c9d6 to a597409 Compare October 3, 2023 12:47
@simosho simosho self-assigned this Oct 3, 2023
@simosho simosho marked this pull request as draft October 3, 2023 12:51
@simosho simosho force-pushed the WPPM-1211-align-severity-level-in-node-and-python-logs branch from a597409 to bcfa1e6 Compare October 3, 2023 12:53
@simosho simosho force-pushed the WPPM-1211-align-severity-level-in-node-and-python-logs branch from bcfa1e6 to 98e48fe Compare October 3, 2023 13:27
@simosho simosho marked this pull request as ready for review October 3, 2023 13:46
@simosho simosho changed the title fix: align levels label to node.js pino-loki labels fix: let props_to_labels take properties from log line Oct 3, 2023
@simosho
Copy link
Copy Markdown
Author

simosho commented Oct 3, 2023

@claudiu-muresan-pfa sorry, I completely changed the PR and moved the actual alignment of level loki label to https://github.com/waylayio/function-logger-py/pull/9

plankthom
plankthom approved these changes Oct 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@plankthom plankthom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@simosho simosho merged commit ab42add into waylay_main Oct 4, 2023
@simosho simosho deleted the WPPM-1211-align-severity-level-in-node-and-python-logs branch October 4, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plankthom plankthom plankthom approved these changes

@claudiu-muresan-pfa claudiu-muresan-pfa claudiu-muresan-pfa approved these changes

Assignees

@simosho simosho

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@simosho @plankthom @claudiu-muresan-pfa