fix(historical): return error instead of panic on unknown timezone#467
Merged
fix(historical): return error instead of panic on unknown timezone#467
Conversation
`parse_time_zone` panicked when IB Gateway sent an unmapped timezone name. Both call sites already return `Result<_, Error>`, so propagate the failure as `Error::UnsupportedTimeZone`, which already carries the `register_timezone_alias` / `IBAPI_TIMEZONE_ALIASES` registration hint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_time_zoneinsrc/market_data/historical/common/decoders/mod.rspanicked whenfind_timezonereturned no match. Both call sites already returnResult<_, Error>, so propagate the failure as the typedError::UnsupportedTimeZone(name.to_string()). Its display already carries theregister_timezone_alias/IBAPI_TIMEZONE_ALIASESregistration hint added in #465.Why
After #465 added
register_timezone_aliasandIBAPI_TIMEZONE_ALIASES, users can extend the alias table at runtime. Butparse_time_zonewould still crash the whole process on an unmapped name in a historical schedule or bar response, defeating the registry escape hatch for the historical-data path. Now the failure is recoverable with the same fix pointers.Test plan
cargo +1.95.0 fmtcargo +1.95.0 clippy --all-targets -- -D warningscargo +1.95.0 clippy --all-targets --features sync -- -D warningscargo +1.95.0 clippy --all-featurescargo +1.95.0 test --features sync(historical: 92 passed)cargo +1.95.0 test --features async(historical: 62 passed)test_decode_historical_schedule_unknown_timezone_errorsexercises the error path, asserts the typed variant viamatches!, and asserts the rendered message containsregister_timezone_aliasandIBAPI_TIMEZONE_ALIASES.Companion PR
v2-stable port: #466.