Conversation
Replace cargo-tarpaulin with cargo-llvm-cov for both CI and the just cover target. Single --all-features run covers sync + async in one pass; drops the prior split sync/async runs and lcov merge. Coverage workflow now triggers on push to main directly (no workflow_run-after-CI gate). Drop CARGO_INCREMENTAL=0 and RUSTFLAGS=-C instrument-coverage env — cargo-llvm-cov manages instrumentation flags itself.
Update CONTRIBUTING.md install instructions and coverage command, AGENTS.md description of the just cover target and artifact path, and drop the stale tarpaulin-report.html .gitignore entry (target/ already covers the new llvm-cov output).
--all-features compiles only one branch of code gated by cfg(all(feature = "sync", not(feature = "async"))) — 12 such gates exist in src/. Run sync and async passes separately with --no-report, then merge via 'cargo llvm-cov report --lcov' so both branches are measured. Also: pin dtolnay/rust-toolchain@1.95.0 (matches ci.yml and rust-toolchain.toml so llvm-tools-preview installs against the right toolchain), drop redundant if: condition (on: already filters push-to-main), drop mkdir (cargo-llvm-cov creates the parent dir), restore allow-empty: true on the Coveralls upload, switch taiki-e/install-action to versioned @v2 form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo-tarpaulinwithcargo-llvm-covin.github/workflows/coverage.ymland thejust covertarget. Single--all-featuresrun covers both sync and async; drops the prior split runs and lcov merge.maindirectly (noworkflow_run-after-CI gate). Drop tarpaulin-era env vars (CARGO_INCREMENTAL=0,RUSTFLAGS=-C instrument-coverage) —cargo-llvm-covmanages instrumentation flags itself.CONTRIBUTING.md,AGENTS.md, and.gitignoreto match.Test plan
coverage/lcov.infoto Coverallsjust coverlocally produces an HTML report undertarget/llvm-cov/html/and opens itmainNotes
rust-toolchain.toml(1.95.0).dtolnay/rust-toolchain@stablein the action is overridden by the toolchain file atcargoinvocation. Happy to swap to an explicit@1.95.0to mirrorci.ymlif preferred.tarpaulin-report.htmlmay exist at the repo root after this change (no longer ignored). Delete locally if undesired.