Add very verbose option

[r-zip]

Pytest has an option for higher verbosity, which will display the full diff for objects that fail equality assertion (-vv). In my work, I've found the flag to be indispensable for TDD. This PR adds the -vv flag as an option in the magit popup menu.

[wbolster]

thanks for your contribution. this seems useful indeed. i usually add it manually, or specify it via addopts in pytest.ini.

i think the implementation can be nicer though: instead of an extra flag, perhaps the -v flag could ‘rotate’ between nothing, --verbose, and --verbose --verbose instead. what do you think?

[r-zip]

I've tried this (you can take a look at my best attempt in the most recent commit), but I don't think there is a way to do this within the magit-popup framework. I think we'd either need to submit a PR upstream for it, or hack around it (which might take a lot of effort for something so simple).

The issue is that we need to maintain some state, which I tried to do by setting the SWITCH argument to a 0-arity function that returns a string and manages a counter for the "verbosity level". It seemed in the docs that this was supported, but it doesn't work, so I must have misread something.

I've never used magit-popup extensively, so let me know if I'm missing anything obvious.

[wbolster]

same here, never used it extensively, and it's semi-deprecated in favour of transient.el. i can't say i like the implementation for the same reasons you mention, and perhaps it can be simplified a bit somehow, but i don't think it's worth it.

let's settle for good enough. thanks!

[wbolster]

you're right, custom lisp functions don't seem to work at all for ‘switches’ (e.g. -x) like they do for ‘options’ (e.g. =x).

the magit-invoke-popup-switch has no funcall, unlike magit-invoke-popup-option:

(defun magit-invoke-popup-switch (event)
  (interactive (list last-command-event))
  (--if-let (magit-popup-lookup event :switches)
      (progn
        (setf (magit-popup-event-use it)
              (not (magit-popup-event-use it)))
        (magit-refresh-popup-buffer))
    (user-error "%c isn't bound to any switch" event)))

(defun magit-invoke-popup-option (event)
  (interactive (list last-command-event))
  (--if-let (magit-popup-lookup event :options)
      (progn
        (if (magit-popup-event-use it)
            (setf (magit-popup-event-use it) nil)
          (let* ((arg (magit-popup-event-arg it))
                 (val (funcall
                       (magit-popup-event-fun it)
                       (concat arg (unless (string-match-p "=$" arg) ": "))
                       (magit-popup-event-val it))))
            (setf (magit-popup-event-use it) t)
            (setf (magit-popup-event-val it) val)))
        (magit-refresh-popup-buffer))
    (user-error "%c isn't bound to any option" event)))

[wbolster]

fwiw, #24 was merged with the original simpler idea: a -w flag